Re: [RFC PATCH] config.mak.uname: add HAVE_DEV_TTY to cygwin config section

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Sep 7, 2024, 13:48 UTC
Message-ID: <4e18ec3b-c536-4bc3-9883-77e35686f5d3@ramsayjones.plus.com>
In-Reply-To: <20240907062112.GA2585439@coredump.intra.peff.net>

On 07/09/2024 07:21, Jeff King wrote:

Show 20 quoted lines

> On Sat, Sep 07, 2024 at 12:53:11AM +0100, Ramsay Jones wrote:
> 
>>> Certainly doesn't hurt to test the single-key mode of "add -p", etc,
>>> though.
>>
>> Yeah, I still need to check the 'other uses' out. Hmm, I have never
>> used 'add -p' (never felt the need), so I guess I will have to read
>> up on how to use it ...
> 
> Try:
> 
>   git init
>   echo foo >file
>   git add file
>   echo bar >file
>   git -c interactive.singleKey=true add -p
> 
> Hitting 'y' or 'n' should immediately be accepted (and exit the program
> either with the hunk staged or not), whereas I suspect it would not
> without HAVE_DEV_TTY.

Oh, that is much better! Everything works exactly as described and is a much better user experience than:

    "warning: reading single keystrokes not supported ..."

:)

Looking good.

Thanks.

ATB, Ramsay Jones