Re: [PATCH] clang-format: adjust line break penalties

From: Stephan Beyer <s-beyer@gmx.net>
Date: Sep 29, 2017, 22:39 UTC
Message-ID: <c1230d5b-ff84-8cf4-8ae7-b8387bf4bb04@gmx.net>
In-Reply-To: <20170929184032.GK19555@aiede.mtv.corp.google.com>

Hi,

On 09/29/2017 08:40 PM, Jonathan Nieder wrote:

> Going forward, is there an easy way to preview the effect of this kind
> of change (e.g., to run "make style" on the entire codebase so as to be
> able to compare the result with two different versions of
> .clang-format)?

I just ran clang-format before and after the patch and pushed to github. The resulting diff is quite big:

https://github.com/sbeyer/git/commit/3d1186c4cf4dd7e40b97453af5fc1170f6868ccd

Cheers Stephan

PS: There should be a comment at the beginning of the .clang-format file
that says what version it is tested with (on my machine it worked with
5.0 but not with 4.0) and there should also probably a remark that the
clang-format-based style should only be understood as a hint or guidance
and that most of the Git codebase does not conform it.