Re: [PATCH] clang-format: adjust line break penalties

From: Brandon Williams <bmwill@google.com>
Date: Sep 29, 2017, 19:50 UTC
Message-ID: <20170929195000.GE177031@google.com>
In-Reply-To: <20170929184032.GK19555@aiede.mtv.corp.google.com>

On 09/29, Jonathan Nieder wrote:

Show 20 quoted lines

> Hi Dscho,
> 
> Johannes Schindelin wrote:
> 
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >  .clang-format | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> Well executed and well explained. Thank you.
> 
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
> 
> Going forward, is there an easy way to preview the effect of this kind
> of change (e.g., to run "make style" on the entire codebase so as to be
> able to compare the result with two different versions of
> .clang-format)?
> 
> Thanks,
> Jonathan

I don't think there's an easy way to do this yet (I'm sure we can make one) though the biggest barrier to that is that most of the code base probably isn't consistent with the current .clang-format.

I also took a look at the patch and agree with all your points. I'm sure we'll still have to do some tweaking of these parameters but I'll start using this locally and see if I find any problems.

-- 
Brandon Williams