git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: New built-in fsmonitor: messages accidentally on stdout?

From
JHJeff Hostetler <git@jeffhostetler.com>
Date
Sep 27, 2021, 13:52 UTC
Message-ID
<c0ff1914-8bf2-fb10-ea74-d35cf86508a1@jeffhostetler.com>
In-Reply-To
<CAPMMpoic0Dt=5Z7GB7BG7CqwxAs49SPPDkdasUPvasvsPhr-tg@mail.gmail.com>
On 9/27/21 5:32 AM, Tao Klerks wrote:
Show 12 quoted lines
> Hi folks,
> 
> I did track down where that message was being issued onto stdout in
> git-for-windows
> (https://github.com/git-for-windows/git/blob/main/builtin/fsmonitor--daemon.c),
> and I see that in the the latest version of the patch series it was
> already switched to stderr
> (https://github.com/jeffhostetler/git/blob/f08a63e197a0efe4d8f0452893238b0d3156e669/builtin/fsmonitor--daemon.c).
> 
> The only remaining thing I can ask for, I guess, is that the next Git
> for Windows release ideally include this change/fix, even though the
> built-in fsmonitor is not in "regular git" at all yet?

Yes, I've fixed that in my branch to print to stderr (and also put it behind a feature flag).

If my current series does not make it into core Git in time for the next release, we will update the experimental version in the next git-for-windows release.

Thanks, Jeff

Previous: Tao KlerksNext: Johannes Schindelin
Message 3 of 4 in “New built-in fsmonitor: messages accidentally on stdout?”
  1. Tao KlerksSep 24, 2021
  2. Tao KlerksSep 27, 2021
  3. Jeff HostetlerSep 27, 2021
  4. Johannes SchindelinOct 5, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.