From: Jeff Hostetler <git@jeffhostetler.com>
Date: Mon, 27 Sep 2021 13:52:39 GMT
Subject: Re: New built-in fsmonitor: messages accidentally on stdout?
Message-ID: <c0ff1914-8bf2-fb10-ea74-d35cf86508a1@jeffhostetler.com>
In-Reply-To: <CAPMMpoic0Dt=5Z7GB7BG7CqwxAs49SPPDkdasUPvasvsPhr-tg@mail.gmail.com>



On 9/27/21 5:32 AM, Tao Klerks wrote:
> Hi folks,
> 
> I did track down where that message was being issued onto stdout in
> git-for-windows
> (https://github.com/git-for-windows/git/blob/main/builtin/fsmonitor--daemon.c),
> and I see that in the the latest version of the patch series it was
> already switched to stderr
> (https://github.com/jeffhostetler/git/blob/f08a63e197a0efe4d8f0452893238b0d3156e669/builtin/fsmonitor--daemon.c).
> 
> The only remaining thing I can ask for, I guess, is that the next Git
> for Windows release ideally include this change/fix, even though the
> built-in fsmonitor is not in "regular git" at all yet?

Yes, I've fixed that in my branch to print to stderr (and also
put it behind a feature flag).

If my current series does not make it into core Git in time
for the next release, we will update the experimental version
in the next git-for-windows release.

Thanks,
Jeff