git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/3] automatically skip away from broken commits

From
Christian Couder <christian.couder@gmail.com>
Date
Jun 9, 2009, 19:28 UTC
Message-ID
<c07716ae0906091228s708058d4vea986239a6b458de@mail.gmail.com>
In-Reply-To
<4A2E7EEC.2050807@zytor.com>
On Tue, Jun 9, 2009 at 5:25 PM, H. Peter Anvin<hpa@zytor.com> wrote:
Show 27 quoted lines
> Christian Couder wrote:
>> On Tue, Jun 9, 2009 at 6:24 AM, Christian
>> Couder<christian.couder@gmail.com> wrote:
>>> So I would be ok to implement a config option or a switch to "git
>>> bisect start" to let people use a PRNG instead of my algorithm but I
>>> think something like my algorithm should be the default.
>>
>> Another reason to have 2 algorithms is that when you use "git bisect
>> run" you might want to use the PRNG one because:
>>
>> - you don't care much if the bisection use some more steps (as long as
>> it does not get stuck)
>> - you can't do much if it get stuck
>>
>> On the other hand, when you bisect manually:
>>
>> - you probably won't like it if you are asked to test some commits
>> that won't give a lot of information
>> - if it get stuck, you can manually use "git bisect visualize" and/or
>> "git bisect skip <range>" and/or some other manual commands to do
>> something about it
>>
>
> Sort-of-kind-of.  I doubt most users will be able to recover from a
> stuck situation, and unless we have extremely high cost of testing
> (which is true for some applications) then expecting the user to
> optimizing manually is really bad user design.

My opinion is that we should not penalize all the people working on "quite clean" projects and also people working on "not clean" projects who are able to recover, on the pretence that there are other people on these "not clean" projects who are not.

I think it's the projects maintainers' responsibility to keep their projects graphs quite clean (and they have the right to ask git developers for the tools to do that). If they don't do so, then their users will suffer anyway. So it's not a big deal to ask them to teach their users to add a "--prng" option to "git bisect start" for example or something like that to try to work around the "not cleanliness" of their graphs.

Best regards, Christian.

Previous: H. Peter AnvinNext: H. Peter Anvin
Message 21 of 37 in “automatically skip away from broken commits”
  1. 0/3 automatically skip away from broken commitsChristian Couder, Jun 6, 2009
  2. 1/3 bisect: add parameters to "filter_skipped"Christian Couder, Jun 6, 2009
  3. 2/3 bisect: when skipping, choose a commit away from a skipped commitChristian Couder, Jun 6, 2009
  4. 3/3 t6030: test skipping away from an already skipped commitChristian Couder, Jun 6, 2009
  5. Junio C HamanoJun 6, 2009
  6. Christian CouderJun 7, 2009
  7. H. Peter AnvinJun 8, 2009
  8. Junio C HamanoJun 8, 2009
  9. H. Peter AnvinJun 8, 2009
  10. Junio C HamanoJun 8, 2009
  11. H. Peter AnvinJun 8, 2009
  12. Christian CouderJun 9, 2009
  13. Jakub NarebskiJun 9, 2009
  14. H. Peter AnvinJun 9, 2009
  15. Jakub NarebskiJun 9, 2009
  16. H. Peter AnvinJun 9, 2009
  17. Christian CouderJun 9, 2009
  18. H. Peter AnvinJun 9, 2009
  19. Junio C HamanoJun 9, 2009
  20. H. Peter AnvinJun 9, 2009
  21. Christian CouderJun 9, 2009
  22. H. Peter AnvinJun 9, 2009
  23. Christian CouderJun 10, 2009
  24. Junio C HamanoJun 9, 2009
  25. Christian CouderJun 10, 2009
  26. Junio C HamanoJun 10, 2009
  27. H. Peter AnvinJun 10, 2009
  28. Christian CouderJun 11, 2009
  29. H. Peter AnvinJun 11, 2009
  30. H. Peter AnvinJun 11, 2009
  31. Christian CouderJun 12, 2009
  32. H. Peter AnvinJun 13, 2009
  33. Jakub NarebskiJun 13, 2009
  34. H. Peter AnvinJun 13, 2009
  35. Christian CouderJun 15, 2009
  36. H. Peter AnvinJun 15, 2009
  37. Christian CouderJun 13, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.