Re: [PATCH v3 0/3] automatically skip away from broken commits
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 9, 2009, 18:35 UTC
- Message-ID
- <7vljo1mf09.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <4A2E7EEC.2050807@zytor.com>
"H. Peter Anvin" <hpa@zytor.com> writes:
> My main objection to the "skip in goodness space" is exactly the same as > Junio's... it doesn't really buy you what it claims to sell.
It is no worse than the original "pick the next best in goodness space"; neither try to avoid the ones close to untestable ones.
So as long as it does not claim "we intelligently try to skip away from untestable ones", I am actually Ok with Christian's patch. It might do worse than the random walk in pathological cases, but I suspect not by a big margin.