Re: [PATCH v2 00/13] meson: cleanups, improvements, smallish fixes
- From
Justin Tobler <jltobler@gmail.com>
- Date
- Feb 7, 2025, 15:22 UTC
- Message-ID
- <bmwazsiuhhf2dk2hxyl76ubpsdtzk5thxohsjry7qwr2cnow53@cm4wqrrqjqu4>
- In-Reply-To
- <20250130-b4-pks-meson-improvements-v2-0-2f05581ffb44@pks.im>
On 25/01/30 03:43PM, Patrick Steinhardt wrote:
Show 22 quoted lines
> Hi, > > this patch series contains a mostly-random set of smallish improvements, > simplifications and fixes to the Meson build instructions. > > Changes in v2: > - Redo the two commits regarding PATH handling. We now only prepend > system-specific paths to PATH and handle the `-Dsane_tool_path` > option the same. > - Continue to propagate libcurl include directories into libgit, as we > need it for "help.c" to resolve LIBCURL_VERSION. Reorder the patch > to minimize the required changes. > - Fix a commit message typo. > - Include another commit that fixes the OpenSSL fallback on Windows. > - Include another commit to fix linker errors due to out-of-memory > situations on Windows with GitLab CI. > - Link to v1: https://lore.kernel.org/r/20250129-b4-pks-meson-improvements-v1-0-ab709f0be12c@pks.im > > I have furthermore pulled in ps/build-meson-fixes at 7304bd2bc3 (ci: > wire up Visual Studio build with Meson, 2025-01-22) as a dependency of > this series. This is due to a semantic conflict with 28911f7dca (meson: > wire up fuzzers, 2025-01-22).
Thanks Patrick! I've reviewed the changes in this version and tested building locally. This version looks good to me.
-Justin