git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 07/11] meson: deduplicate the list of required programs

From
Patrick Steinhardt <ps@pks.im>
Date
Jan 29, 2025, 07:12 UTC
Message-ID
<20250129-b4-pks-meson-improvements-v1-7-ab709f0be12c@pks.im>
In-Reply-To
<20250129-b4-pks-meson-improvements-v1-0-ab709f0be12c@pks.im>

When setting up Meson we detect a couple of executables that we rely on in order to build Git and prepend their respective directories to PATH. This is done so that Windows can locate these tools at build time in case they aren't included in the default PATH, as we know to pick up those required build tools from the Git for Windows path explicitly.

The list of executables we check against is somewhat excessive though, as many of the tools are all part of coreutils. Let's deduplicate them so that we only check for one binary that is part of it, namely cat(1).

Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 1e1e478d17..48eb068fd8 100644
--- a/meson.build
+++ b/meson.build
@@ -187,7 +187,7 @@ shell = find_program('sh', dirs: program_path)
 tar = find_program('tar', dirs: program_path)
 
 script_environment = environment()
-foreach tool : ['cat', 'cut', 'grep', 'sed', 'sort', 'tr', 'uname']
+foreach tool : ['cat', 'grep', 'sed']
   program = find_program(tool, dirs: program_path)
   script_environment.prepend('PATH', fs.parent(program.full_path()))
 endforeach
-- 
2.48.1.362.g079036d154.dirty
Previous: Patrick SteinhardtNext: Justin Tobler
Message 9 of 35 in “meson: cleanups, improvements, smallish fixes”
  1. 00/11 meson: cleanups, improvements, smallish fixesPatrick Steinhardt, Jan 29, 2025
  2. 01/11 meson: fix exec path with enabled runtime prefixPatrick Steinhardt, Jan 29, 2025
  3. Justin ToblerJan 29, 2025
  4. Patrick SteinhardtJan 30, 2025
  5. 02/11 meson: inline the static 'git' libraryPatrick Steinhardt, Jan 29, 2025
  6. 04/11 meson: stop linking libcurl into all executablesPatrick Steinhardt, Jan 29, 2025
  7. 03/11 meson: simplify use of the common-main libraryPatrick Steinhardt, Jan 29, 2025
  8. 05/11 meson: introduce `libgit_curl` dependencyPatrick Steinhardt, Jan 29, 2025
  9. 07/11 meson: deduplicate the list of required programsPatrick Steinhardt, Jan 29, 2025
  10. Justin ToblerJan 29, 2025
  11. 06/11 meson: drop separate version libraryPatrick Steinhardt, Jan 29, 2025
  12. 08/11 meson: simplify setup of PATH environment variablePatrick Steinhardt, Jan 29, 2025
  13. Justin ToblerJan 29, 2025
  14. Patrick SteinhardtJan 30, 2025
  15. 09/11 meson: prevent finding sed(1) in a loopPatrick Steinhardt, Jan 29, 2025
  16. 10/11 meson: fix overwritten `git` variablePatrick Steinhardt, Jan 29, 2025
  17. 11/11 meson: consistently use custom program paths to resolve programsPatrick Steinhardt, Jan 29, 2025
  18. 00/13 meson: cleanups, improvements, smallish fixesPatrick Steinhardt, Jan 30, 2025
  19. 02/13 meson: fix OpenSSL fallback when not explicitly requiredPatrick Steinhardt, Jan 30, 2025
  20. 01/13 meson: fix exec path with enabled runtime prefixPatrick Steinhardt, Jan 30, 2025
  21. 03/13 meson: inline the static 'git' libraryPatrick Steinhardt, Jan 30, 2025
  22. 04/13 meson: simplify use of the common-main libraryPatrick Steinhardt, Jan 30, 2025
  23. 06/13 meson: stop linking libcurl into all executablesPatrick Steinhardt, Jan 30, 2025
  24. 05/13 meson: introduce `libgit_curl` dependencyPatrick Steinhardt, Jan 30, 2025
  25. 07/13 meson: drop separate version libraryPatrick Steinhardt, Jan 30, 2025
  26. Toon ClaesFeb 7, 2025
  27. 08/13 meson: improve PATH handlingPatrick Steinhardt, Jan 30, 2025
  28. 09/13 meson: improve handling of `sane_tool_path` optionPatrick Steinhardt, Jan 30, 2025
  29. Toon ClaesFeb 7, 2025
  30. Patrick SteinhardtFeb 7, 2025
  31. 10/13 meson: prevent finding sed(1) in a loopPatrick Steinhardt, Jan 30, 2025
  32. 11/13 meson: fix overwritten `git` variablePatrick Steinhardt, Jan 30, 2025
  33. 12/13 meson: consistently use custom program paths to resolve programsPatrick Steinhardt, Jan 30, 2025
  34. 13/13 gitlab-ci: restrict maximum number of link jobs on WindowsPatrick Steinhardt, Jan 30, 2025
  35. Justin ToblerFeb 7, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.