Re: [PATCH v2] Show usage string for 'git http-push -h'
- From
Tay Ray Chuan <rctay89@gmail.com>
- Date
- Nov 9, 2009, 13:56 UTC
- Message-ID
- <be6fef0d0911090556u77dbc1fah458e6a8b37ffa2cb@mail.gmail.com>
- In-Reply-To
- <20091109104732.GA15519@progeny.tock>
Hi,
On Mon, Nov 9, 2009 at 6:47 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 5 quoted lines
> (I was making sure "git http-push -h" would work without a git > directory by putting the check for -h before setup_git_directory(). > But nothing in the argv loop requires a git repository, so it is > better and simpler to move the setup_git_directory() call to after the > loop. Thanks for the catch.)
Actually, I didn't notice the removal of the "is in a git directory for -h" requirement; I was only looking at the argument mix.
Thanks.
Acked-by: Tay Ray Chuan <rctay89@gmail.com>
-- Cheers, Ray Chuan