Re: [PATCH 20/24] http-fetch: add missing initialization of argv0_path
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 10, 2009, 20:12 UTC
- Message-ID
- <7vpr7q6sw8.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1257779104-23884-20-git-send-email-jrnieder@gmail.com>
Jonathan Nieder <jrnieder@gmail.com> writes:
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> > ---
Why do you have inclusion of "exec_cmd.h" in [19/24]? As far as I can tell, nothing you do in that patch depends on it.
According to c6dfb39 (remote-curl: add missing initialization of argv0_path, 2009-10-13), this patch is necessary (and you must include "exec_cmd.h") on MinGW, regardless of the "give help upon -h" topic.
I think this should be ejected from your series go directly to 'maint', or am I mistaken?
http-fetch.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/http-fetch.c b/http-fetch.c index e8f44ba..88f7dc8 100644 --- a/http-fetch.c +++ b/http-fetch.c @@ -1,4 +1,5 @@ #include "cache.h" +#include "exec_cmd.h" #include "walker.h" int main(int argc, const char **argv) @@ -19,8 +20,8 @@ int main(int argc, const char **argv) int get_verbosely = 0; int get_recover = 0; + git_extract_argv0_path(argv[0]); prefix = setup_git_directory(); - git_config(git_default_config, NULL); while (arg < argc && argv[arg][0] == '-') {