git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] http*: cleanup slot->local after fclose

From
Tay Ray Chuan <rctay89@gmail.com>
Date
May 31, 2009, 08:48 UTC
Message-ID
<be6fef0d0905310148g7ee7a642jf6a9661d6e62b40b@mail.gmail.com>
In-Reply-To
<7vy6sdssnk.fsf@alter.siamese.dyndns.org>
Hi,
On Sun, May 31, 2009 at 2:17 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Shouldn't a fix instead be queued for 'maint', without "refactoring"?
one on the way.
> Is there a reproducible repipe you can add to the test script?

what do you mean by "repipe"? To my mind, reproducing Clemens' issue would require some code manipulation and compiling.

> Hmm, what's the point of setting NULL to request->slot if you are already
> freeing "request" that contains the field?
you do have a point. :)
-- 
Cheers,
Ray Chuan
Previous: Junio C HamanoNext: Tay Ray Chuan
Message 10 of 15 in “http-push: send out fetch requests on queue”
  1. 3/3 http-push: send out fetch requests on queueTay Ray Chuan, Apr 24, 2009
  2. Clemens BuchacherMay 30, 2009
  3. Tay Ray ChuanMay 30, 2009
  4. Clemens BuchacherMay 30, 2009
  5. Tay Ray ChuanMay 30, 2009
  6. Tay Ray ChuanMay 30, 2009
  7. http*: cleanup slot->local after fcloseTay Ray Chuan, May 30, 2009
  8. Clemens BuchacherMay 30, 2009
  9. Junio C HamanoMay 31, 2009
  10. Tay Ray ChuanMay 31, 2009
  11. http*: cleanup slot->local after fcloseTay Ray Chuan, May 31, 2009
  12. Junio C HamanoMay 31, 2009
  13. Tay Ray ChuanJun 1, 2009
  14. Junio C HamanoJun 1, 2009
  15. Tay Ray ChuanJun 2, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.