From: Tay Ray Chuan Date: Sun, 31 May 2009 08:48:58 GMT Subject: Re: [PATCH] http*: cleanup slot->local after fclose Message-ID: In-Reply-To: <7vy6sdssnk.fsf@alter.siamese.dyndns.org> Hi, On Sun, May 31, 2009 at 2:17 PM, Junio C Hamano wrote: > Shouldn't a fix instead be queued for 'maint', without "refactoring"? one on the way. > Is there a reproducible repipe you can add to the test script? what do you mean by "repipe"? To my mind, reproducing Clemens' issue would require some code manipulation and compiling. > Hmm, what's the point of setting NULL to request->slot if you are already > freeing "request" that contains the field? you do have a point. :) -- Cheers, Ray Chuan