Re: [RFC PATCH] Make the rebase edit mode really end up in an edit state

From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Jan 15, 2009, 12:45 UTC
Message-ID: <bd6139dc0901150445l51f3b861n5bbd85bb6d1382b6@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.0901151325310.3586@pacific.mpi-cbg.de>

On Thu, Jan 15, 2009 at 13:36, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

> If at all, I'd introduce 'examine' as a synonym to 'edit' (might be more
> intuitive).

Examine suggests that you cannot change the commit (you can look, but don't touch it!), no?

> However, for the same reason (is it intuitive?) I am not fully convinced
> of 'amend' either.  Because --amend _can_ mean that you change the
> diff of the commit.  Maybe 'correct', 'redact' or 'rephrase'?

OTOH, when you have no changes staged "git commit --ammend" will do exactly that, it will let you edit the commit message of the last commit.

> BTW I was not fully happy with 'edit' back then, either, which is the
> reason why I showed the usage in the comment _above_ the commit list.  But
> nobody could suggest a name that I found convincingly better.

The coder's law #349: "The hardest part of writing new functionality is coming up with a proper name that everyone agrees on".

-- 
Cheers,

Sverre Rabbelier