Re: [PATCH] Use SHELL_PATH

From: Sverre Rabbelier <alturin@gmail.com>
Date: Jul 16, 2008, 10:47 UTC
Message-ID: <bd6139dc0807160347n2ebcd64fy7a15fe94bfabe580@mail.gmail.com>
In-Reply-To: <g5jj21$bsp$1@ger.gmane.org>

On Wed, Jul 16, 2008 at 3:31 AM, SungHyun Nam <goweol@gmail.com> wrote:

Show 21 quoted lines

>
> Signed-off-by: SungHyun Nam <goweol@gmail.com>
> ---
>  t/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/t/Makefile b/t/Makefile
> index a778865..0d65ced 100644
> --- a/t/Makefile
> +++ b/t/Makefile
> @@ -26,7 +26,7 @@ clean:
>        $(RM) -r 'trash directory' test-results
>
>  aggregate-results:
> -       ./aggregate-results.sh test-results/t*-*
> +       '$(SHELL_PATH_SQ)' ./aggregate-results.sh test-results/t*-*
>
>  # we can test NO_OPTIMIZE_COMMITS independently of LC_ALL
>  full-svn-test:
> --
> 1.5.6.3.350.g6c11a

It is not clear to me what this patch does, there is no justification in the commit msg either. Instead you say what is being done, which we can see from the commit diff. Please clarify?

-- 
Cheers,

Sverre Rabbelier