Re: [PATCH] Use SHELL_PATH
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 16, 2008, 16:05 UTC
- Message-ID
- <7vej5tu84y.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <7vr69tu91e.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 7 quoted lines
> It wants to make sure that the shell specified from the toplevel Makefile > (or from make command line) is used to run the aggregation script. It is > often necessary when platform /bin/sh is not quite POSIX (e.g. the script > in question uses arithmetic expansion "$(( $var1 + $var2 ))"). > > Just saying "Use specified shell to run shell scripts" on the title line > would be sufficient, but I wonder if this is the only remaining place...
People on funny platforms might find this one useful, which is consistent with the way the patch under discussion called the shell. This lets you to say
SHELL_PATH = /Program Files/GNU/Bash
or something silly like that ;-)
Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile index 9b52071..a2b2627 100644 --- a/Makefile +++ b/Makefile @@ -153,7 +153,7 @@ all:: # broken, or spawning external process is slower than built-in grep git has). GIT-VERSION-FILE: .FORCE-GIT-VERSION-FILE - @$(SHELL_PATH) ./GIT-VERSION-GEN + @'$(SHELL_PATH_SQ)' ./GIT-VERSION-GEN -include GIT-VERSION-FILE uname_S := $(shell sh -c 'uname -s 2>/dev/null || echo not')