git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] Modified test-lib.sh to output stats to /tmp/git-test-results

From
Sverre Rabbelier <srabbelier@gmail.com>
Date
Jun 8, 2008, 19:02 UTC
Message-ID
<bd6139dc0806081202l48953181q7d337455c85bbe2c@mail.gmail.com>
In-Reply-To
<7vabhvkbbi.fsf@gitster.siamese.dyndns.org>
On Sun, Jun 8, 2008 at 8:53 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Some tests may chdir around and when you hit test_done they may not be in
> the directory directly under t/ anymore.  I'd say that such a test is
> ill-mannered, but we would want to protect ourselves against such mischief
> somehow.

Ah, I guess logging to /tmp/git-test-result was more reliable then. Any suggestions as to what is the best solution here? (We could for example save $PWD at the beginning of test-lib.sh.)

Show 7 quoted lines
> Also, this won't be an immediate issue, but we may want to lift the
> ".NOTPARALLEL" limitation in t/Makefile sometime in the future.  A handful
> tests need to be adjusted for this change, as they currently refer their
> test vectors in t/tXXXX/ as ../tXXXX, and with such a change, we would run
> each test in "t/trash directory/t$$" where $$ is the pid, or something
> like that.  A single "test-results" file everybody races to append would
> become unwieldy at that point.  Something to keep in mind.

Ah, yes, I was going to have each test log to their own file (test-results-$$) and then cat the result together, but I figured that since we are .NOTPARALLEL anyway it would be more efficient not to. I reckon that whenever we decide to make such a change it will be then that we modify this script, if it is included?

-- 
Cheers,

Sverre Rabbelier
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 9 in “Modified test-lib.sh to output stats to /tmp/git-test-results”
  1. 1/3 Modified test-lib.sh to output stats to /tmp/git-test-resultsSverre Rabbelier, Jun 8, 2008
  2. 2/3 A simple script to parse the results from the testcasesSverre Rabbelier, Jun 8, 2008
  3. 3/3 Hook up the result aggregation in the test makefile.Sverre Rabbelier, Jun 8, 2008
  4. Jakub NarebskiJun 8, 2008
  5. Sverre RabbelierJun 8, 2008
  6. Junio C HamanoJun 8, 2008
  7. Sverre RabbelierJun 8, 2008
  8. Junio C HamanoJun 8, 2008
  9. 4/4 Make test-lib warn if the directory changes.Sverre Rabbelier, Jun 9, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.