Re: [PATCH 1/3] Modified test-lib.sh to output stats to /tmp/git-test-results
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 8, 2008, 20:59 UTC
- Message-ID
- <7vej77iqxb.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <bd6139dc0806081202l48953181q7d337455c85bbe2c@mail.gmail.com>
"Sverre Rabbelier" <srabbelier@gmail.com> writes:
> Ah, I guess logging to /tmp/git-test-result was more reliable then. > Any suggestions as to what is the best solution here? (We could for > example save $PWD at the beginning of test-lib.sh.)
Saving at the beginning to use in test_done, and optionally detecting that cwd was changed and warn, would be sensible, I think.
Show 5 quoted lines
> Ah, yes, I was going to have each test log to their own file > (test-results-$$) and then cat the result together, but I figured that > since we are .NOTPARALLEL anyway it would be more efficient not to. I > reckon that whenever we decide to make such a change it will be then > that we modify this script, if it is included?
Yup. That is what I meant by "not immediate, but something to keep in mind".