[GSoC PATCH v6 1/6] pack-write: add explanation to promisor file content
- From
LorenzoPegorari <lorenzo.pegorari2002@gmail.com>
- Date
- Apr 18, 2026, 14:16 UTC
- Message-ID
- <bc1e3eb244117ed0ad8a7fd3f2bf180f085eacdc.1776384902.git.lorenzo.pegorari2002@gmail.com>
- In-Reply-To
- <cover.1776384902.git.lorenzo.pegorari2002@gmail.com>
In the entire codebase there is no explanation as to why the ".promisor" files may contain the ref names (and their associated hashes) that were fetched at the time the corresponding packfile was downloaded.
As explained in the log message of commit 5374a290 (fetch-pack: write fetched refs to .promisor, 2019-10-14), where this loop originally came from, these ref names (and associated hashes) are not used for anything in the production, but are solely there to help debugging.
Explain this in a new comment.
Helped-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: LorenzoPegorari <lorenzo.pegorari2002@gmail.com> --- pack-write.c | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/pack-write.c b/pack-write.c index 83eaf88541..b8ab9510ff 100644 --- a/pack-write.c +++ b/pack-write.c @@ -603,6 +603,15 @@ void write_promisor_file(const char *promisor_name, struct ref **sought, int nr_ int i, err; FILE *output = xfopen(promisor_name, "w"); + /* + * Write in the .promisor file the ref names and associated hashes, + * obtained by fetch-pack, at the point of generation of the + * corresponding packfile. These pieces of info are only used to make + * it easier to debug issues with partial clones, as we can identify + * what refs (and their associated hashes) were fetched at the time + * the packfile was downloaded, and if necessary, compare those hashes + * against what the promisor remote reports now. + */ for (i = 0; i < nr_sought; i++) fprintf(output, "%s %s\n", oid_to_hex(&sought[i]->old_oid), sought[i]->name);
-- 2.53.0.584.g6b87e8e9dd