Re: [GSoC PATCH v3 2/5] pack-write: add helper to fill promisor file after repack

From: Lorenzo Pegorari <lorenzo.pegorari2002@gmail.com>
Date: Apr 7, 2026, 21:46 UTC
Message-ID: <adV7Nq2fqA-Rz3JK@lorenzo-VM>
In-Reply-To: <xmqqeckraiwh.fsf@gitster.g>

On Mon, Apr 06, 2026 at 02:17:02PM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> Also strbuf_split*() is a bad API.  Unless you need all the parts[]
> strbuf instances all editable at the same time, an array of strbuf
> is a data structure that is way overkill.  Splitting into string-list
> may make it more palatable, I think.
> 
> We even went through a series of patches (and follow-up effort by
> other contributors) [*] to rewrite callers that unnecessarily call
> strbuf_split*().
> 
> [References]
>   https://lore.kernel.org/git/20250731225433.4028872-1-gitster@pobox.com/
>   https://lore.kernel.org/git/cover.1761217100.git.belkid98@gmail.com/

Mhm makes perfect sense. I will rewrite it using `string_list`. Thanks!

Lorenzo