git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] ref-filter: mark some file-local symbols as static

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Jul 12, 2018, 15:57 UTC
Message-ID
<bbd5f6f5-8587-606e-01be-4c5e37609037@ramsayjones.plus.com>
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Olga,

If you need to re-roll your 'ot/ref-filter-object-info' branch, could you please squash this into the relevant patch (commit c5d9a471d6, "ref-filter: use oid_object_info() to get object", 2018-07-09).

[Both sparse and my static-check.pl script are complaining about the 'oi' and 'oi_deref' symbols.]

Thanks!

ATB, Ramsay Jones

 ref-filter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ref-filter.c b/ref-filter.c
index 9aedf29e0..70fb15619 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -63,7 +63,7 @@ struct refname_atom {
 	int lstrip, rstrip;
 };
 
-struct expand_data {
+static struct expand_data {
 	struct object_id oid;
 	enum object_type type;
 	unsigned long size;
-- 
2.18.0
Next: Оля Тележная
Message 1 of 2 in “ref-filter: mark some file-local symbols as static”
  1. ref-filter: mark some file-local symbols as staticRamsay Jones, Jul 12, 2018
  2. Оля ТележнаяJul 12, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.