Re: [PATCH] ref-filter: mark some file-local symbols as static

From: Оля Тележная <olyatelezhnaya@gmail.com>
Date: Jul 12, 2018, 17:07 UTC
Message-ID: <CAL21Bm=eqEV8qXECvXBm5Nqx6Wgbsha7ya=pEvTuqw+F-FncDg@mail.gmail.com>
In-Reply-To: <bbd5f6f5-8587-606e-01be-4c5e37609037@ramsayjones.plus.com>

2018-07-12 18:57 GMT+03:00 Ramsay Jones <ramsay@ramsayjones.plus.com>:

Show 12 quoted lines

>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Olga,
>
> If you need to re-roll your 'ot/ref-filter-object-info' branch,
> could you please squash this into the relevant patch (commit c5d9a471d6,
> "ref-filter: use oid_object_info() to get object", 2018-07-09).
>
> [Both sparse and my static-check.pl script are complaining about
> the 'oi' and 'oi_deref' symbols.]

You are right. Thanks a lot!

Show 24 quoted lines

>
> Thanks!
>
> ATB,
> Ramsay Jones
>
>  ref-filter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ref-filter.c b/ref-filter.c
> index 9aedf29e0..70fb15619 100644
> --- a/ref-filter.c
> +++ b/ref-filter.c
> @@ -63,7 +63,7 @@ struct refname_atom {
>         int lstrip, rstrip;
>  };
>
> -struct expand_data {
> +static struct expand_data {
>         struct object_id oid;
>         enum object_type type;
>         unsigned long size;
> --
> 2.18.0