Re: [PATCH 1/7] gitk: Enhance UI popup and accelerator handling.

From: Alexander Gavrilov <angavrilov@gmail.com>
Date: Oct 16, 2008, 22:08 UTC
Message-ID: <bb6f213e0810161508l68b0548bsbee5e81ef7830b4a@mail.gmail.com>
In-Reply-To: <18679.47194.852924.385301@cargo.ozlabs.ibm.com>

On Fri, Oct 17, 2008 at 1:55 AM, Paul Mackerras <paulus@samba.org> wrote:

Show 15 quoted lines

> Alexander Gavrilov writes:
>> - Popups are supposed to be marked transient, otherwise
>>   the WM creates them in strange places. Besides, at
>>   least under kwin, transients are automatically kept
>>   above their parent.
>
> I agree with most of the places where you add wm transient commands,
> but in the case of the list of references (showrefs), I think of that
> as a long-lived window that one would normally place beside the main
> window.  (In fact, it should be a pane in the main window, but I
> couldn't think of a place for it.  Maybe I should split the
> bottom-right pane in two.)
>
> So I don't think the wm transient in showrefs is what we want.
> Comments?

On the other hand, wm transient makes it always stay on top of the main window. If the main window is maximized, it is useful.

Btw, gitk probably should not save its geometry if the window is maximized, because when it is started again the window is too large.

Alexander