Re: [PATCH 1/7] gitk: Enhance UI popup and accelerator handling.

From: Paul Mackerras <paulus@samba.org>
Date: Oct 16, 2008, 21:55 UTC
Message-ID: <18679.47194.852924.385301@cargo.ozlabs.ibm.com>
In-Reply-To: <1223449540-20457-2-git-send-email-angavrilov@gmail.com>

Alexander Gavrilov writes:

> - Popups are supposed to be marked transient, otherwise
>   the WM creates them in strange places. Besides, at
>   least under kwin, transients are automatically kept
>   above their parent.

I agree with most of the places where you add wm transient commands, but in the case of the list of references (showrefs), I think of that as a long-lived window that one would normally place beside the main window. (In fact, it should be a pane in the main window, but I couldn't think of a place for it. Maybe I should split the bottom-right pane in two.)

So I don't think the wm transient in showrefs is what we want. Comments?

Paul.