Re: [RFC/PATCH 1/2] Teach Solaris that _XOPEN_SOURCE=600 really menas XPG6

From: Brandon Casey <casey@nrlssc.navy.mil>
Date: Jun 11, 2009, 15:50 UTC
Message-ID: <bUVdoksYaP8iWWwjmEaaKuJWLMjhg9vaKu35QNnhoSMM0G7B3XoanQ@cipher.nrlssc.navy.mil>
In-Reply-To: <B96700A1-EC8C-4DDE-A158-CE298FCCA09F@dbservice.com>

Tomas Carnecky wrote:

> 
> On May 23, 2009, at 9:24 PM, Junio C Hamano wrote:

Show 24 quoted lines

>> diff --git a/git-compat-util.h b/git-compat-util.h
>> index c7cf2d5..4236647 100644
>> --- a/git-compat-util.h
>> +++ b/git-compat-util.h
>> @@ -41,8 +41,10 @@
>>
>> #if !defined(__APPLE__) && !defined(__FreeBSD__)  &&
>> !defined(__USLC__) && !defined(_M_UNIX)
>> #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD
>> needs 600 for S_ISLNK() */
>> +#ifndef __sun__
>> #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */
>> #endif
>> +#endif
>> #define _ALL_SOURCE 1
>> #define _GNU_SOURCE 1
>> #define _BSD_SOURCE 1
>> -- 
>> 1.6.3.1.145.gb74d77
>>
> 
> Until this commit a simple 'make prefix=...' worked just fine. Now I
> have to explicitly add '-std=c99' to the gcc commandline. Is there a
> reason why the makefile doesn't add this switch automatically?

There are additionally patches on 'next' and more in the pipeline on 'pu' which adjust these feature macros when compiling on Solaris. See the bc/solaris series 8fccb00 which was merged to 'pu'.

Also, if you happen to be using the Sun Studio suite 12 with c-compiler version 5.9, I'd be interested to know whether you can compile diff-delta.c, or whether you get an error (see commit 203ee91f).

-brandon