Re: [PATCH v7 03/15] t6060: add tests for removed files

From: Alban Gruin <alban.gruin@gmail.com>
Date: Mar 23, 2021, 20:43 UTC
Message-ID: <b9d48a96-7e76-8a83-4ca2-c47fca326123@gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.2103222235150.50@tvgsbejvaqbjf.bet>

Hi Johannes,

Le 22/03/2021 à 22:36, Johannes Schindelin a écrit :

Show 8 quoted lines

> Hi Alban,
> 
> On Wed, 17 Mar 2021, Alban Gruin wrote:
> 
>> Until now, t6060 did not not check git-mere-one-file's behaviour when a
> 
> Channeling my inner Eric Sunshine: s/mere-one/merge-one/ ;-)
>

Good catch.

Show 5 quoted lines

>> file is deleted in a branch.  To avoid regressions on this during the
>> conversion, this adds a new file, `file3', in the commit tagged as`base', and
> 
> Maybe "during the conversion from shell script to C"?
>

I'll rewrite it as "during the conversion from shell to C".

Cheers, Alban

> Other than that, looks good to me! Thanks,
> Dscho
>

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.