Re: [PATCH 3/5] reftable/writer: simplify writing index records
- From
Kristoffer Haugsbakk <code@khaugsbakk.name>
- Date
- Jan 31, 2024, 15:55 UTC
- Message-ID
- <b96f8ce1-f597-447b-b410-e135626e03d0@app.fastmail.com>
- In-Reply-To
- <b0982baacf74a4501ce5c543b294bc15d6937875.1706263918.git.ps@pks.im>
Hi
It looks like this isn’t in `next` yet so I’ll leave a comment.
Show 5 quoted lines
> @@ -405,6 +405,7 @@ static int writer_finish_section(struct reftable_writer *w) > w->index = NULL; > w->index_len = 0; > w->index_cap = 0; > +
This part and the next quoted one seem to be an unrelated edit by `clang-format`. They could perhaps be grouped in their own patch.
Show 10 quoted lines
> - abort();
> - }
> }
> - for (i = 0; i < idx_len; i++) {
> +
> + for (i = 0; i < idx_len; i++)
> strbuf_release(&idx[i].last_key);
> - }
> reftable_free(idx);
> }-- Kristoffer Haugsbakk