[PATCH v2 3/5] reftable/writer: simplify writing index records
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Feb 1, 2024, 07:52 UTC
- Message-ID
- <b3de0b7f3b3dfbe9cfa6a20220e20cb884b3539c.1706773842.git.ps@pks.im>
- In-Reply-To
- <cover.1706773842.git.ps@pks.im>
When finishing the current section some index records might be written for the section to the table. The logic that adds these records to the writer duplicates what we already have in `writer_add_record()`, making this more complicated than it really has to be.
Simplify the code by using `writer_add_record()` instead. While at it, drop the unneeded braces around a loop to make the code conform to our code style better.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- reftable/writer.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-)
diff --git a/reftable/writer.c b/reftable/writer.c index 5a0b87b406..b5bcce0292 100644 --- a/reftable/writer.c +++ b/reftable/writer.c @@ -412,26 +412,14 @@ static int writer_finish_section(struct reftable_writer *w) .idx = idx[i], }, }; - if (block_writer_add(w->block_writer, &rec) == 0) { - continue; - } - err = writer_flush_block(w); + err = writer_add_record(w, &rec); if (err < 0) return err; - - writer_reinit_block_writer(w, BLOCK_TYPE_INDEX); - - err = block_writer_add(w->block_writer, &rec); - if (err != 0) { - /* write into fresh block should always succeed - */ - abort(); - } } - for (i = 0; i < idx_len; i++) { + + for (i = 0; i < idx_len; i++) strbuf_release(&idx[i].last_key); - } reftable_free(idx); }
-- 2.43.GIT