git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] ci: avoid ugly "failure" in the `ci-config` job

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Sep 1, 2020, 20:19 UTC
Message-ID
<b92374e69192d57bcb11fb2573beb4e9aee339a9.1598991568.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.719.git.1598991568.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

In the common case where users have _not_ pushed a `ci-config` branch to configure which branches should be included in the GitHub workflow runs, there is a big fat ugly annotation about a failure in the run's log:

	X Check failure on line 1 in .github
	  @github-actions github-actions / ci-config
	  .github#L1
	  Process completed with exit code 128.

The reason is that the `ci-config` job tries to clone that `ci-config` branch, and even if it is configured to continue on error, the annotation is displayed, and it is distracting.

Let's just handle this on the shell script level, so that the job's step is not marked as a failure.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 .github/workflows/main.yml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 6fd1d1a2c8..fcfd138ff1 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -12,7 +12,6 @@ jobs:
       enabled: ${{ steps.check-ref.outputs.enabled }}
     steps:
       - name: try to clone ci-config branch
-        continue-on-error: true
         run: |
           git -c protocol.version=2 clone \
             --no-tags \
@@ -24,7 +23,7 @@ jobs:
             https://github.com/${{ github.repository }} \
             config-repo &&
           cd config-repo &&
-          git checkout HEAD -- ci/config
+          git checkout HEAD -- ci/config || : ignore
       - id: check-ref
         name: check whether CI is enabled for ref
         run: |
-- 
gitgitgadget
Previous: Jeff KingNext: Jeff King
Message 4 of 6 in “ci: avoid ugly "failure" annotation in the GitHub workflow”
  1. 0/2 ci: avoid ugly "failure" annotation in the GitHub workflowJohannes Schindelin via GitGitGadget, Sep 1, 2020
  2. 1/2 ci: fix indentation of the `ci-config` jobJohannes Schindelin via GitGitGadget, Sep 1, 2020
  3. Jeff KingSep 2, 2020
  4. 2/2 ci: avoid ugly "failure" in the `ci-config` jobJohannes Schindelin via GitGitGadget, Sep 1, 2020
  5. Jeff KingSep 2, 2020
  6. Junio C HamanoSep 2, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.