git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] ci: fix indentation of the `ci-config` job

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Sep 1, 2020, 20:19 UTC
Message-ID
<b5363e282f69570e34ffb806f7a62e00e39b98bc.1598991568.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.719.git.1598991568.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

The section added in e76eec35540f (ci: allow per-branch config for GitHub Actions, 2020-05-07) contains a `&&`-chain that connects several commands. The first command is actually so long that it stretches over multiple lines, and as per usual, the continuation lines are indented one more level than the first.

However, the subsequent commands in the `&&`-chain were also indented one more level than the first command, which was almost certainly unintended.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 .github/workflows/main.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 30425404eb..6fd1d1a2c8 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -23,8 +23,8 @@ jobs:
             --filter=blob:none \
             https://github.com/${{ github.repository }} \
             config-repo &&
-            cd config-repo &&
-            git checkout HEAD -- ci/config
+          cd config-repo &&
+          git checkout HEAD -- ci/config
       - id: check-ref
         name: check whether CI is enabled for ref
         run: |
-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadgetNext: Jeff King
Message 2 of 6 in “ci: avoid ugly "failure" annotation in the GitHub workflow”
  1. 0/2 ci: avoid ugly "failure" annotation in the GitHub workflowJohannes Schindelin via GitGitGadget, Sep 1, 2020
  2. 1/2 ci: fix indentation of the `ci-config` jobJohannes Schindelin via GitGitGadget, Sep 1, 2020
  3. Jeff KingSep 2, 2020
  4. 2/2 ci: avoid ugly "failure" in the `ci-config` jobJohannes Schindelin via GitGitGadget, Sep 1, 2020
  5. Jeff KingSep 2, 2020
  6. Junio C HamanoSep 2, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.