Re: Memory leak with sparse-checkout
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Sep 20, 2021, 17:27 UTC
- Message-ID
- <b7ee5ff5-dfff-8d3f-36f6-b30daf2d71ec@gmail.com>
- In-Reply-To
- <b082f98b-eb49-7cc4-9f75-fe1ec480bd61@gmail.com>
On 9/20/2021 1:25 PM, Derrick Stolee wrote:
Show 7 quoted lines
> On 9/20/2021 12:42 PM, Taylor Blau wrote: >> We would probably want to perform this check both during initialization, >> and when adding patterns in cone mode. It may also be worthwhile to >> check the validity of the cone before running 'list' or 'reapply', too. > > 'list' definitely seems like a good idea, since it is expecting different > output than the literal patterns when cone mode is enabled.
I double-checked this to see how to fix this, and the 'list' subcommand already notices that the patterns are not in cone mode and reverts its behavior to writing all of the sparse-checkout file to stdout. It also writes warnings over stderr before that.
There might not be anything pressing to do here.
Thanks, -Stolee