git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Memory leak with sparse-checkout

From
Taylor Blau <me@ttaylorr.com>
Date
Sep 22, 2021, 19:37 UTC
Message-ID
<YUuF4SKO4lA/xLKZ@nand.local>
In-Reply-To
<98bd3b94-eb8d-b074-b89d-d86dcefaa995@gmail.com>
On Wed, Sep 22, 2021 at 03:16:22PM -0400, Derrick Stolee wrote:
Show 17 quoted lines
> On 9/21/2021 4:45 PM, Taylor Blau wrote:
> [...]
> > I fear that we're talking about different things. With your patches, if
> > I munge my .git/info/sparse-checkout file, I can easily get something
> > like:
> >
> >   $ git.compile sparse-checkout list
> >   warning: unrecognized pattern: 'foo'
> >   warning: disabling cone pattern matching
> >
> > to appear. But I'm wondering why the same doesn't happen when running
> > `git sparse-checkout init --cone` while the existing sparse-checkout
> > definition contains non-cone mode entries.
>
> You don't get that warning because it's not trying to parse the
> previous patterns using cone mode. Before my series, you would get
> the warning in a _second_ run of "git sparse-checkout init --cone".

OK. I was confused because in [1] you said that we produce this error any time we try to load the existing definitions and parse them in cone-mode.

I would have assumed that we would try to do that during `init --cone` to read the existing sparse-checkout definition.

Thanks, Taylor

[1]: https://lore.kernel.org/git/734ecf93-e563-20d5-7cf1-74048aa74d56@gmail.com/
Previous: Derrick Stolee
Message 15 of 15 in “Memory leak with sparse-checkout”
  1. CalbabreakerSep 20, 2021
  2. Taylor BlauSep 20, 2021
  3. Derrick StoleeSep 20, 2021
  4. Taylor BlauSep 20, 2021
  5. Derrick StoleeSep 20, 2021
  6. Derrick StoleeSep 20, 2021
  7. Taylor BlauSep 20, 2021
  8. Derrick StoleeSep 20, 2021
  9. Taylor BlauSep 20, 2021
  10. Derrick StoleeSep 21, 2021
  11. Taylor BlauSep 21, 2021
  12. Derrick StoleeSep 21, 2021
  13. Taylor BlauSep 21, 2021
  14. Derrick StoleeSep 22, 2021
  15. Taylor BlauSep 22, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.