Re: [PATCH v4] remote: allow specifying refs to prefetch

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Nov 5, 2024, 14:47 UTC
Message-ID: <b548c532-e54a-4edc-94aa-f3c2925602e6@gmail.com>
In-Reply-To: <Zym--GVNJt_lsQEz@pks.im>

On 05/11/2024 06:45, Patrick Steinhardt wrote:

Show 20 quoted lines

> On Fri, Oct 04, 2024 at 08:21:32PM +0000, Shubham Kanodia via GitGitGadget wrote:
> 
>> diff --git a/Documentation/config/remote.txt b/Documentation/config/remote.txt
>> index 8efc53e836d..186f439ed7b 100644
>> --- a/Documentation/config/remote.txt
>> +++ b/Documentation/config/remote.txt
>> @@ -33,6 +33,13 @@ remote.<name>.fetch::
>>   	The default set of "refspec" for linkgit:git-fetch[1]. See
>>   	linkgit:git-fetch[1].
>>   
>> +remote.<name>.prefetchref::
>> +	Specify the refs to be prefetched when fetching from this
>> +	remote. The value is a space-separated list of ref patterns
>> +	(e.g., "refs/heads/main !refs/heads/develop*"). This can be
>> +	used to optimize fetch operations by specifying exactly which
>> +	refs should be prefetched.
> 
> I'm a bit surprised that we use a space-separated list here instead of
> accepting a multi-valued config like we do for "remote.<name>.fetch".
> Shouldn't we use the format here to make things more consistent?

I agree that would be a good idea. I also think that it would be helpful to expand the documentation to explain exactly how the patterns are matched. I think "remote.<name>.prefetch" would better match the existing "remote.<name>.fetch" and "remote.<push>.name" config key names.

Best Wishes

Phillip