git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] advice: refactor "action is not possible because you have unmerged files"

From
René Scharfe <l.s.r@web.de>
Date
Jan 19, 2022, 11:11 UTC
Message-ID
<b49ba26e-e41b-c597-aeb4-d76c6011fbca@web.de>
In-Reply-To
<20220119094445.15542-3-bagasdotme@gmail.com>
Am 19.01.22 um 10:44 schrieb Bagas Sanjaya:
Show 33 quoted lines
> Factor action names (cherry-picking, committing, merging, pulling, and
> reverting) out of the message string.
>
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
>  advice.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/advice.c b/advice.c
> index 1dfc91d176..4c72856478 100644
> --- a/advice.c
> +++ b/advice.c
> @@ -175,15 +175,15 @@ void list_config_advices(struct string_list *list, const char *prefix)
>  int error_resolve_conflict(const char *me)
>  {
>  	if (!strcmp(me, "cherry-pick"))
> -		error(_("Cherry-picking is not possible because you have unmerged files."));
> +		error(_("%s is not possible because you have unmerged files."), "Cherry-picking");
>  	else if (!strcmp(me, "commit"))
> -		error(_("Committing is not possible because you have unmerged files."));
> +		error(_("%s is not possible because you have unmerged files."), "Commiting");
>  	else if (!strcmp(me, "merge"))
> -		error(_("Merging is not possible because you have unmerged files."));
> +		error(_("%s is not possible because you have unmerged files."), "Merging");
>  	else if (!strcmp(me, "pull"))
> -		error(_("Pulling is not possible because you have unmerged files."));
> +		error(_("%s is not possible because you have unmerged files."), "Pulling");
>  	else if (!strcmp(me, "revert"))
> -		error(_("Reverting is not possible because you have unmerged files."));
> +		error(_("%s is not possible because you have unmerged files."), "Reverting");
>  	else
>  		error(_("It is not possible to %s because you have unmerged files."),
>  			me);

That effectively reverts 8785c42532 (i18n: advice: internationalize message for conflicts, 2016-06-17). Why? Having the capitalized English present participle of the action appear somewhere in a translated string would sure look quite foreign in some (most?) languages.

René
Previous: Bagas SanjayaNext: Ævar Arnfjörð Bjarmason
Message 5 of 8 in “More similar messages refactoring”
  1. 0/2 More similar messages refactoringBagas Sanjaya, Jan 19, 2022
  2. 1/2 sequencer: factor GIT_AUTHOR_* from message stringsBagas Sanjaya, Jan 19, 2022
  3. Jean-Noël AVILAFeb 11, 2022
  4. 2/2 advice: refactor "action is not possible because you have unmerged files"Bagas Sanjaya, Jan 19, 2022
  5. René ScharfeJan 19, 2022
  6. Ævar Arnfjörð BjarmasonJan 19, 2022
  7. Jean-Noël AVILAJan 19, 2022
  8. Junio C HamanoJan 19, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.