git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] sequencer: factor GIT_AUTHOR_* from message strings

From
Bagas Sanjaya <bagasdotme@gmail.com>
Date
Jan 19, 2022, 09:44 UTC
Message-ID
<20220119094445.15542-2-bagasdotme@gmail.com>
In-Reply-To
<20220119094445.15542-1-bagasdotme@gmail.com>
Factor messages containing GIT_AUTHOR_* variable.
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
 sequencer.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/sequencer.c b/sequencer.c
index 6abd72160c..472feb053c 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -848,17 +848,17 @@ int read_author_script(const char *path, char **name, char **email, char **date,
 	for (i = 0; i < kv.nr; i++) {
 		if (!strcmp(kv.items[i].string, "GIT_AUTHOR_NAME")) {
 			if (name_i != -2)
-				name_i = error(_("'GIT_AUTHOR_NAME' already given"));
+				name_i = error(_("'%s' already given"), "GIT_AUTHOR_NAME");
 			else
 				name_i = i;
 		} else if (!strcmp(kv.items[i].string, "GIT_AUTHOR_EMAIL")) {
 			if (email_i != -2)
-				email_i = error(_("'GIT_AUTHOR_EMAIL' already given"));
+				email_i = error(_("'%s' already given"), "GIT_AUTHOR_EMAIL");
 			else
 				email_i = i;
 		} else if (!strcmp(kv.items[i].string, "GIT_AUTHOR_DATE")) {
 			if (date_i != -2)
-				date_i = error(_("'GIT_AUTHOR_DATE' already given"));
+				date_i = error(_("'%s' already given"), "GIT_AUTHOR_DATE");
 			else
 				date_i = i;
 		} else {
@@ -867,11 +867,11 @@ int read_author_script(const char *path, char **name, char **email, char **date,
 		}
 	}
 	if (name_i == -2)
-		error(_("missing 'GIT_AUTHOR_NAME'"));
+		error(_("missing '%s'"), "GIT_AUTHOR_NAME");
 	if (email_i == -2)
-		error(_("missing 'GIT_AUTHOR_EMAIL'"));
+		error(_("missing '%s'"), "GIT_AUTHOR_EMAIL");
 	if (date_i == -2)
-		error(_("missing 'GIT_AUTHOR_DATE'"));
+		error(_("missing '%s'"), "GIT_AUTHOR_DATE");
 	if (date_i < 0 || email_i < 0 || date_i < 0 || err)
 		goto finish;
 	*name = kv.items[name_i].util;
-- 
An old man doll... just what I always wanted! - Clara
Previous: Bagas SanjayaNext: Jean-Noël AVILA
Message 2 of 8 in “More similar messages refactoring”
  1. 0/2 More similar messages refactoringBagas Sanjaya, Jan 19, 2022
  2. 1/2 sequencer: factor GIT_AUTHOR_* from message stringsBagas Sanjaya, Jan 19, 2022
  3. Jean-Noël AVILAFeb 11, 2022
  4. 2/2 advice: refactor "action is not possible because you have unmerged files"Bagas Sanjaya, Jan 19, 2022
  5. René ScharfeJan 19, 2022
  6. Ævar Arnfjörð BjarmasonJan 19, 2022
  7. Jean-Noël AVILAJan 19, 2022
  8. Junio C HamanoJan 19, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.