git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/1] archive: init archivers before determining format

From
steadmon@google.com <steadmon@google.com>
Date
Oct 19, 2018, 23:19 UTC
Message-ID
<b1f8e288dde9a9dd46386524189da66c7ad2c333.1539990488.git.steadmon@google.com>
In-Reply-To
<cover.1539990488.git.steadmon@google.com>

When passing both --remote and --output to git-archive, initialize the archivers before attempting to determine the format from the output filename. Without initialization, the format cannot be determined.

Signed-off-by: Josh Steadmon <steadmon@google.com>
---
 builtin/archive.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/builtin/archive.c b/builtin/archive.c
index e74f675390..dd3283a247 100644
--- a/builtin/archive.c
+++ b/builtin/archive.c
@@ -45,7 +45,10 @@ static int run_remote_archiver(int argc, const char **argv,
 	 * it.
 	 */
 	if (name_hint) {
-		const char *format = archive_format_from_filename(name_hint);
+		const char *format;
+		init_tar_archiver();
+		init_zip_archiver();
+		format = archive_format_from_filename(name_hint);
 		if (format)
 			packet_write_fmt(fd[1], "argument --format=%s\n", format);
 	}
-- 
2.19.1.568.g152ad8e336-goog
Previous: steadmon@google.comNext: Jeff King
Message 2 of 20 in “Fix format detection when archiving remotely”
  1. 0/1 Fix format detection when archiving remotelysteadmon@google.com, Oct 19, 2018
  2. 1/1 archive: init archivers before determining formatsteadmon@google.com, Oct 19, 2018
  3. Jeff KingOct 19, 2018
  4. Junio C HamanoOct 22, 2018
  5. Josh SteadmonOct 22, 2018
  6. Jeff KingOct 22, 2018
  7. Jeff KingOct 19, 2018
  8. Josh SteadmonOct 22, 2018
  9. archive: initialize archivers earliersteadmon@google.com, Oct 22, 2018
  10. Jeff KingOct 22, 2018
  11. Josh SteadmonOct 22, 2018
  12. Jeff KingOct 23, 2018
  13. Josh SteadmonOct 23, 2018
  14. archive: initialize archivers earliersteadmon@google.com, Oct 22, 2018
  15. archive: initialize archivers earliersteadmon@google.com, Oct 23, 2018
  16. Junio C HamanoOct 23, 2018
  17. Josh SteadmonOct 25, 2018
  18. archive: initialize archivers earliersteadmon@google.com, Oct 25, 2018
  19. Jeff KingOct 25, 2018
  20. Junio C HamanoOct 26, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.