Re: [PATCH 0/1] Fix format detection when archiving remotely

From: Jeff King <peff@peff.net>
Date: Oct 19, 2018, 23:41 UTC
Message-ID: <20181019234126.GA7326@sigill.intra.peff.net>
In-Reply-To: <cover.1539990488.git.steadmon@google.com>

On Fri, Oct 19, 2018 at 04:19:27PM -0700, steadmon@google.com wrote:

Show 8 quoted lines

> Currently, git-archive does not properly determine the desired archive
> format when both --output and --remote are provided, because
> run_remote_archiver() does not initialize the archivers prior to calling
> archive_format_from_filename(). This results in the remote archiver
> always returning a TAR file, regardless of the requested format.
> 
> This patch initializes the TAR and ZIP archivers before calling
> archive_format_from_filename(), which fixes format detection.

It seems like some of this content could be in the commit message of the actual patch.

Show 11 quoted lines

> Steps to reproduce:
> 
> ∫ git version
> git version 2.19.1.568.g152ad8e336-goog
> ∫ cd ~/src/git
> ∫ git archive --output ~/good.zip HEAD
> ∫ file ~/good.zip
> /home/steadmon/good.zip: Zip archive data, at least v1.0 to extract
> ∫ git archive --output ~/bad.zip --remote=. HEAD
> ∫ file ~/bad.zip
> /home/steadmon/bad.zip: POSIX tar archive

And this could be in a test script in the actual patch. :)

-Peff