Re: [PATCH 0/2] gitweb use sections

> On Thu, Jul 31, 2008 at 5:32 PM, Petr Baudis <pasky@suse.cz> wrote:
>>  Hi,
>>
>> On Thu, Jul 31, 2008 at 04:43:35PM -0300, Gustavo Sverzut Barbieri wrote:
>>> Since nobody replied and I missed some gitweb guys in CC, I'm adding
>>> Petr and Jakub, as some guys said on IRC.
>>>
>>> Have anyone tried this patch, any problems?
>>
>>  sorry, I have it in my review queue. At first pass it was looking
>> good, but I wanted to look at it better before commenting.
>
> no problem, just to see it was noticed or not :-)
>
>
>>  One thing I'm wondering about is how to make this stuff configurable,
>> since I'm not very comfortable with adding more "unbound" configuration
>> variables and would rather prefer stuff to be added to the $features
>> array... I'm not at all sure about my own sentiment here, however.
>
> Path comparison (first patch), Sections (second), both?
>
> I know path comparison can be a performance hit on large listings on
> sites with heavy traffic. However, I don't see many people accessing
> the projects page at the same time for long periods, it's not like
> slashdot... people mostly use it to know about repositories and then
> use git to track it.
>    The slowness is due O(n^2) worst case of sort and each step is not
> a bit heavier since it need to split path into components and walk
> these. Maybe cache the split?
>
> --
> Gustavo Sverzut Barbieri
> http://profusion.mobi embedded systems
> --------------------------------------
> MSN: barbieri@gmail.com
> Skype: gsbarbieri
> Mobile: +55 (19) 9225-2202
>