Re: [PATCH 0/2] gitweb use sections

From: Petr Baudis <pasky@suse.cz>
Date: Jul 31, 2008, 20:32 UTC
Message-ID: <20080731203250.GO10151@machine.or.cz>
In-Reply-To: <b1f2b8c40807311243i5689683avcc3c3c91e4e6a900@mail.gmail.com>

Hi,

On Thu, Jul 31, 2008 at 04:43:35PM -0300, Gustavo Sverzut Barbieri wrote:

> Since nobody replied and I missed some gitweb guys in CC, I'm adding
> Petr and Jakub, as some guys said on IRC.
> 
> Have anyone tried this patch, any problems?

  sorry, I have it in my review queue. At first pass it was looking
good, but I wanted to look at it better before commenting.

  One thing I'm wondering about is how to make this stuff configurable,
since I'm not very comfortable with adding more "unbound" configuration
variables and would rather prefer stuff to be added to the $features
array... I'm not at all sure about my own sentiment here, however.

-- 
				Petr "Pasky" Baudis
As in certain cults it is possible to kill a process if you know
its true name.  -- Ken Thompson and Dennis M. Ritchie