Re: [RFC PATCH 4/6] sequencer.c: avoid empty statements at top level

From: ig@drbeat.li <ig@drbeat.li>
Date: Jul 9, 2018, 09:37 UTC
Message-ID: <b1427480e2b70c2ad1ab5873409e5fdc@drbeat.li>
In-Reply-To: <AED9D71037D249F8A56FDF0B1AA48603@PhilipOakley>

Am 08.07.2018 23:17, schrieb Philip Oakley:

Show 6 quoted lines

> From: "Eric Sunshine" <sunshine@sunshineco.com>
> To: "Beat Bolli" <dev+git@drbeat.li>
>> On Sun, Jul 8, 2018 at 10:44 AM Beat Bolli <dev+git@drbeat.li> wrote:
>>> The marco GIT_PATH_FUNC expands to a complete statement including the
> 
> s/marco/macro/

ACK. In addition, the whole sentence is wrong: GIT_PATH_FUNC defines a function, not a statement. Will be fixes in a reroll.

Show 17 quoted lines

>>> semicolon. Remove two extra trailing semicolons.
>>> 
>>> Signed-off-by: Beat Bolli <dev+git@drbeat.li>
>>> ---
>>>  sequencer.c | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> While you're at it, perhaps it would be a good idea to fix the example
>> in path.h which teaches the "wrong" way:
>> 
>> /*
>> * You can define a static memoized git path like:
>> *
>> *    static GIT_PATH_FUNC(git_path_foo, "FOO");
>> *
>> * or use one of the global ones below.
>> */

Thanks, Beat