Re: [ANNOUNCE] Stacked Git 0.15-rc1

From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Jul 14, 2009, 14:12 UTC
Message-ID: <b0943d9e0907140712i39818abfldd01b8f8bb0fe301@mail.gmail.com>
In-Reply-To: <20090713082859.GA10549@pengutronix.de>

2009/7/13 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:

Show 33 quoted lines

>        stg goto include-linux-delay-h-in-hwlat_detector.patch
>        git show --stat
>
> yields:
>
>        commit 12c06d44017a9c51746290779fc24fb8d69c68ef
>        Author: Uwe Kleine-König <=?utf-8?q?Uwe=20Kleine-K=C3=B6nig?=>
>        Date:   Mon Jul 13 10:01:19 2009 +0200
>
>            Subject: include linux/delay.h in hwlat_detector
>                <u.kleine-koenig@pengutronix.de>
>            Date: Sun, 14 Jun 2009 23:31:42 +0200
>
>            This broke when compiling on i386 without X86_LOCAL_APIC because then
>            arch/x86/include/asm/smp.h doesn't include asm/apic.h which in turn includes
>            linux/delay.h.
>
>            Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>            Cc: Jon Masters <jcm@redhat.com>
>            LKML-Reference: <1245015102-22057-1-git-send-email-u.kleine-koenig@pengutron
>            Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>            Cc: Thomas Gleixner <tglx@linutronix.de>
>            Cc: Jon Masters <jcm@redhat.com>
>
>         drivers/misc/hwlat_detector.c |    1 +
>         1 files changed, 1 insertions(+), 0 deletions(-)
>
> There are some things to enhance:
>
>  - s/Subject: //
>  - use Date line as author date
>  - stray email address
>  - author ident is wrong/broken

Can you try stg import -m? If all the patches have Subject: (From: etc.), git show displays:

commit 7718bb00156313687ae42c3ae9d157c558bacb15
Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date:   Sun Jun 14 23:31:42 2009 +0200

    include linux/delay.h in hwlat_detector

    This broke when compiling on i386 without X86_LOCAL_APIC because then
    arch/x86/include/asm/smp.h doesn't include asm/apic.h which in turn includes
    linux/delay.h.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Cc: Jon Masters <jcm@redhat.com>
    LKML-Reference: <1245015102-22057-1-git-send-email-u.kleine-koenig@pengutron
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Jon Masters <jcm@redhat.com>

If there are mixed patches, we may need some kind of autodetection but it seems that most rt patches follow this rule. If there is no description (kbuild.patch), stgit seems to insert None.

-- 
Catalin