Re: [ANNOUNCE] Stacked Git 0.15-rc1

From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Jul 13, 2009, 08:28 UTC
Message-ID: <20090713082859.GA10549@pengutronix.de>
In-Reply-To: <b0943d9e0907121540n4b9199e2re3152e71d84a0f5@mail.gmail.com>

Hi Catalin,

On Sun, Jul 12, 2009 at 11:40:05PM +0100, Catalin Marinas wrote:

> The first release candidate for StGit 0.15 is available from the
> git://repo.or.cz/stgit.git or http://download.gna.org/stgit/. Bugs can
> be reported on the Git mailing list or via the project bugs page
> (https://gna.org/bugs/?group=stgit).

Try this:

	git clone --depth=10 git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.29.y.git
	wget http://www.kernel.org/pub/linux/kernel/projects/rt/patch-2.6.29.6-rt23-broken-out.tar.bz2
	tar xjf patch-2.6.29.6-rt23-broken-out.tar.bz2
	cd linux-2.6.29.y
	git checkout -b 2.6.29-rt v2.6.29.6
	stg init
	stg import -s ../patches/series

(Nice, 0.14.2-1 from Debian failed here, because of a line break in a
From: header.)

But still:

	stg goto include-linux-delay-h-in-hwlat_detector.patch
	git show --stat

yields:

	commit 12c06d44017a9c51746290779fc24fb8d69c68ef
	Author: Uwe Kleine-König <=?utf-8?q?Uwe=20Kleine-K=C3=B6nig?=>
	Date:   Mon Jul 13 10:01:19 2009 +0200

	    Subject: include linux/delay.h in hwlat_detector
		<u.kleine-koenig@pengutronix.de>
	    Date: Sun, 14 Jun 2009 23:31:42 +0200
	    
	    This broke when compiling on i386 without X86_LOCAL_APIC because then
	    arch/x86/include/asm/smp.h doesn't include asm/apic.h which in turn includes
	    linux/delay.h.
	    
	    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
	    Cc: Jon Masters <jcm@redhat.com>
	    LKML-Reference: <1245015102-22057-1-git-send-email-u.kleine-koenig@pengutron
	    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
	    Cc: Thomas Gleixner <tglx@linutronix.de>
	    Cc: Jon Masters <jcm@redhat.com>

	 drivers/misc/hwlat_detector.c |    1 +
	 1 files changed, 1 insertions(+), 0 deletions(-)

There are some things to enhance:

  - s/Subject: //
  - use Date line as author date
  - stray email address
  - author ident is wrong/broken

If you look on arm-__builtin_return_address-works-with-argument-0.patch there the author is broken in an other way:

	stg goto arm-__builtin_return_address-works-with-argument-0.patch
	git show | grep Author:

yields:

	Author: =?utf-8?q?Uwe=20Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>

Note that git quiltimport using git mailinfo gets all that right. (e.g.

	git checkout -b 2.6.29-rt-quiltimport v2.6.29.6
	git quiltimport --author="do <nt@kn.ow>" --patches=../patches/)
	git log --author=Uwe
	git mailinfo msg patch < ../patches/include-linux-delay-h-in-hwlat_detector.patch
	cat msg
)

Best regards Uwe