Re: [PATCH 3/4] Convert git_id() to the new id format

From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Aug 21, 2008, 21:39 UTC
Message-ID: <b0943d9e0808211439x748b7b02s8c2fe21c2e9ea719@mail.gmail.com>
In-Reply-To: <20080714070739.GG20751@diana.vm.bytemark.co.uk>

2008/7/14 Karl Hasselström <kha@treskal.com>:

Show 12 quoted lines

> On 2008-07-13 12:40:48 +0100, Catalin Marinas wrote:
>
>> @@ -67,8 +64,8 @@ def func(parser, options, args):
>>                  rev = strip_suffix('/', rev)
>>                  if rev.endswith('/'):
>>                      rev = strip_suffix('/', rev)
>> -                rev1 = rev + '//bottom'
>> -                rev2 = rev + '//top'
>> +                rev1 = rev + 'HEAD^'
>> +                rev2 = rev + 'HEAD'
>
> This looks bogus. You probably want to s/HEAD// here.

Actually, the full "if" block here is useless. This was to specify diff -r patch/ to show a patch but we now have the "show" command.

> I guess the test suite doesn't cover this? :-(

And it shouldn't, I removed it :-)

-- 
Catalin