Re: [PATCH 3/4] Convert git_id() to the new id format

From: Karl Hasselström <kha@treskal.com>
Date: Jul 14, 2008, 07:07 UTC
Message-ID: <20080714070739.GG20751@diana.vm.bytemark.co.uk>
In-Reply-To: <20080713114047.18845.34899.stgit@localhost.localdomain>

On 2008-07-13 12:40:48 +0100, Catalin Marinas wrote:

Show 8 quoted lines

> @@ -67,8 +64,8 @@ def func(parser, options, args):
>                  rev = strip_suffix('/', rev)
>                  if rev.endswith('/'):
>                      rev = strip_suffix('/', rev)
> -                rev1 = rev + '//bottom'
> -                rev2 = rev + '//top'
> +                rev1 = rev + 'HEAD^'
> +                rev2 = rev + 'HEAD'

This looks bogus. You probably want to s/HEAD// here.

I guess the test suite doesn't cover this? :-(

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle