git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [StGit PATCH] Test that we can add a new file to a non-topmost patch with refresh -p

From
CMCatalin Marinas <catalin.marinas@gmail.com>
Date
Jul 25, 2008, 21:37 UTC
Message-ID
<b0943d9e0807251437u4c01fb45n98e1b0b29e9c4c78@mail.gmail.com>
In-Reply-To
<20080722071438.GA16807@diana.vm.bytemark.co.uk>
2008/7/22 Karl Hasselström <kha@treskal.com>:
Show 8 quoted lines
> On 2008-07-21 23:01:17 +0100, Catalin Marinas wrote:
>
>> I don't think we should spend time on fixing the current code as you
>> already have a new implementation. Maybe we could add a simple test
>> and refuse refreshing other than the topmost patch in case of files
>> added to the index.
>
> Yes, I guess that's OK. Hmm, how do we check that cheaply?

In the stable branch, we already call git.check_status() in the refresh implementation, so it's pretty cheap to test.

-- 
Catalin
Previous: Karl Hasselström
Message 9 of 9 in “stgit: bug with refresh and -p”
  1. Jon SmirlJul 18, 2008
  2. Karl HasselströmJul 18, 2008
  3. Test that we can add a new file to a non-topmost patch with refresh -pKarl Hasselström, Jul 18, 2008
  4. Karl HasselströmJul 18, 2008
  5. Jon SmirlJul 18, 2008
  6. Karl HasselströmJul 18, 2008
  7. Catalin MarinasJul 21, 2008
  8. Karl HasselströmJul 22, 2008
  9. Catalin MarinasJul 25, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.