From: Catalin Marinas Date: Fri, 25 Jul 2008 21:37:23 GMT Subject: Re: [StGit PATCH] Test that we can add a new file to a non-topmost patch with refresh -p Message-ID: In-Reply-To: <20080722071438.GA16807@diana.vm.bytemark.co.uk> 2008/7/22 Karl Hasselström : > On 2008-07-21 23:01:17 +0100, Catalin Marinas wrote: > >> I don't think we should spend time on fixing the current code as you >> already have a new implementation. Maybe we could add a simple test >> and refuse refreshing other than the topmost patch in case of files >> added to the index. > > Yes, I guess that's OK. Hmm, how do we check that cheaply? In the stable branch, we already call git.check_status() in the refresh implementation, so it's pretty cheap to test. -- Catalin