Re: [StGIT] Failure to install on RHELWS4

From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Jul 11, 2008, 21:35 UTC
Message-ID: <b0943d9e0807111435h414697faj8a9f789ddc6a938@mail.gmail.com>
In-Reply-To: <20080711200735.GK10347@genesis.frugalware.org>

2008/7/11 Miklos Vajna <vmiklos@frugalware.org>:

Show 12 quoted lines

> On Fri, Jul 11, 2008 at 09:26:29PM +0200, Thomas Rast <trast@student.ethz.ch> wrote:
>> >         pyver = '.'.join(str(n) for n in sys.version_info)
>> >                                   ^
>> [...]
>> > Python version is 2.3.4
>>
>> That is indeed too old.  Generator expressions like the above were
>> introduced in 2.4:
>>
>>   http://www.python.org/dev/peps/pep-0289/
>
> So obviously it's a bad idea to use generators for such a version check.

Yes, I agree.

> Also, setup.py would try to import stgit.run before the version check.
>
> I'm sending two patches, which restore the wished "Python version 2.4 or
> newer required. Found 2.2.1.final.0" error message.

Thanks.

-- 
Catalin