git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] setup.py: don't try to import stgit.run before the python version check

From
Karl Hasselström <kha@treskal.com>
Date
Jul 16, 2008, 04:39 UTC
Message-ID
<20080716043956.GA31132@diana.vm.bytemark.co.uk>
In-Reply-To
<1215806972-18713-2-git-send-email-vmiklos@frugalware.org>
On 2008-07-11 22:09:32 +0200, Miklos Vajna wrote:
Show 9 quoted lines
> @@ -68,6 +67,8 @@ if sys.argv[1] in ['install', 'build']:
>      __check_python_version()
>      __check_git_version()
>  
> +from stgit.run import Run
> +
>  # ensure readable template files
>  old_mask = os.umask(0022)
>  
I had to modify the second hunk to make it work:
@@ -37,6 +36,7 @@ def __check_python_version():
 def __check_git_version():
     """Check the minimum GIT version
     """
+    from stgit.run import Run
     gitver = Run('git', '--version').output_one_line().split()[2]
     if not __check_min_version(git_min_ver, gitver):
         print >> sys.stderr, 'GIT version %s or newer required. Found %s' \
-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle
Previous: Miklos VajnaNext: Karl Hasselström
Message 6 of 8 in “[StGIT] Failure to install on RHELWS4”
  1. Petr BaudisJul 11, 2008
  2. Thomas RastJul 11, 2008
  3. Miklos VajnaJul 11, 2008
  4. setup.py: fix error message when running with python-2.3Miklos Vajna, Jul 11, 2008
  5. setup.py: don't try to import stgit.run before the python version checkMiklos Vajna, Jul 11, 2008
  6. Karl HasselströmJul 16, 2008
  7. Karl HasselströmJul 12, 2008
  8. Catalin MarinasJul 11, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.