Re: [StGit PATCH] Try the built-in version string before git-describe
- From
- Catalin Marinas <catalin.marinas@gmail.com>
- Date
- May 21, 2008, 14:38 UTC
- Message-ID
- <b0943d9e0805210738v40b25d54j65e70b3ef2745987@mail.gmail.com>
- In-Reply-To
- <20080520213844.13410.32757.stgit@yoghurt>
On 20/05/2008, Karl Hasselström <kha@treskal.com> wrote:
Show 11 quoted lines
> Try to get the built-in version string first, and fall back to git > describe if there is no built-in string, instead of the other way > around. This makes computing the version string much cheaper in the > common case (whenever StGit is not run directly from a git-controlled > tree). > > In order for this to work when StGit _is_ run directly from a > git-controlled tree, setup.py has to delete the builtin version file > once the installation process is over. (Otherwise, the StGit version > in a git-controlled tree would be frozen at whatever value it happened > to have when setup.py was last run.)
OK, I thought it was only the ordering change. With this change to setup.py, I'm OK with the patch. I'll merge your tree tonight.
-- Catalin