Re: [StGit PATCH] Try the built-in version string before git-describe
- From
Karl Hasselström <kha@treskal.com>
- Date
- May 21, 2008, 15:00 UTC
- Message-ID
- <20080521150026.GC31982@diana.vm.bytemark.co.uk>
- In-Reply-To
- <b0943d9e0805210738v40b25d54j65e70b3ef2745987@mail.gmail.com>
On 2008-05-21 15:38:18 +0100, Catalin Marinas wrote:
Show 10 quoted lines
> On 20/05/2008, Karl Hasselström <kha@treskal.com> wrote: > > > In order for this to work when StGit _is_ run directly from a > > git-controlled tree, setup.py has to delete the builtin version > > file once the installation process is over. (Otherwise, the StGit > > version in a git-controlled tree would be frozen at whatever value > > it happened to have when setup.py was last run.) > > OK, I thought it was only the ordering change. With this change to > setup.py, I'm OK with the patch. I'll merge your tree tonight.
The change to setup.py is actually tiny. I just had to reindent a gazillion line, which makes the patch less than perfectly readable...
--
Karl Hasselström, kha@treskal.com
www.treskal.com/kalle